On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks <brian.bro...@arm.com> wrote: > On 04/04 21:55:06, Maxim Uvarov wrote: >> this patch should be not part of this serries and can go to master as >> standalone patch. > > Can you help to cherry pick such patches to master? They need to remain > in this patch series until they are cherry picked to master and master > is sync'd into api-next. At that point I can drop them from this patch > series. Does this make sense? > >> No need of camel case is shor description. Long >> description in git comment is required. > > I'm not sure what to put for the long description because the short > description is succinct enough. Can you provide an example for this > specific commit?
Maxim is just saying is that the ODP convention is that the short log (first line of the commit message) is always all lower-case. > >> Maxim. >> >> >> On 04/04/17 21:47, Brian Brooks wrote: >> > Signed-off-by: Brian Brooks <brian.bro...@arm.com> >> > --- >> > configure.ac | 30 ++++++++++++++++-------------- >> > 1 file changed, 16 insertions(+), 14 deletions(-) >> > >> > diff --git a/configure.ac b/configure.ac >> > index 419c136f..da091ab1 100644 >> > --- a/configure.ac >> > +++ b/configure.ac >> > @@ -304,20 +304,22 @@ ODP_CFLAGS="$ODP_CFLAGS -std=c99" >> > # Extra flags for example to suppress certain warning types >> > ODP_CFLAGS="$ODP_CFLAGS $ODP_CFLAGS_EXTRA" >> > >> > -######################################################################### >> > -# Check if compiler supports cmpxchng16 >> > -########################################################################## >> > -if test "${CC}" != "gcc" -o ${CC_VERSION_MAJOR} -ge 5; then >> > - my_save_cflags="$CFLAGS" >> > - >> > - CFLAGS=-mcx16 >> > - AC_MSG_CHECKING([whether CC supports -mcx16]) >> > - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([])], >> > - [AC_MSG_RESULT([yes])] >> > - [ODP_CFLAGS="$ODP_CFLAGS $CFLAGS"], >> > - [AC_MSG_RESULT([no])] >> > - ) >> > - CFLAGS="$my_save_cflags" >> > +########################################################################## >> > +# Check if compiler supports cmpxchng16 on x86-based architectures >> > +########################################################################## >> > +if "${host}" == i?86* -o "${host}" == x86*; then >> > + if test "${CC}" != "gcc" -o ${CC_VERSION_MAJOR} -ge 5; then >> > + my_save_cflags="$CFLAGS" >> > + >> > + CFLAGS=-mcx16 >> > + AC_MSG_CHECKING([whether CC supports -mcx16]) >> > + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([])], >> > + [AC_MSG_RESULT([yes])] >> > + [ODP_CFLAGS="$ODP_CFLAGS $CFLAGS"], >> > + [AC_MSG_RESULT([no])] >> > + ) >> > + CFLAGS="$my_save_cflags" >> > + fi >> > fi >> > >> > ########################################################################## >> > >>