This is clearly orthogonal to this patch series. Ideally you should
(a) Create a Bug to represent this, (b) Post the fix patch noting the
Bug URL in the commit log, and (c) update the Bug entry with the URL
of the patch that fixes this bug.

On Tue, Apr 4, 2017 at 1:47 PM, Brian Brooks <brian.bro...@arm.com> wrote:
> Signed-off-by: Kevin Wang <kevin.w...@arm.com>
> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com>
> Reviewed-by: Brian Brooks <brian.bro...@arm.com>
> ---
>  platform/linux-generic/pktio/loop.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/platform/linux-generic/pktio/loop.c 
> b/platform/linux-generic/pktio/loop.c
> index 70962839..49d8a211 100644
> --- a/platform/linux-generic/pktio/loop.c
> +++ b/platform/linux-generic/pktio/loop.c
> @@ -176,6 +176,7 @@ static int loopback_send(pktio_entry_t *pktio_entry, int 
> index ODP_UNUSED,
>                 pktio_entry->s.stats.out_octets += bytes;
>         } else {
>                 ODP_DBG("queue enqueue failed %i\n", ret);
> +               odp_ticketlock_unlock(&pktio_entry->s.txl);
>                 return -1;

A better fix to this is to just delete the return -1 since that will
result in the following unlock being executed and ret being returned
as the return code from this routine.

>         }
>
> --
> 2.12.2
>

Reply via email to