Reviewed-and-tested-by: Petri Savolainen <petri.savolai...@linaro.org>

Currently make check (api-next) fails on the parser test (tap pktio) in my 
system. This patch corrects that. Please merge soon.

-Petri


> -----Original Message-----
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Matias Elo
> Sent: Thursday, April 06, 2017 5:41 PM
> To: lng-odp@lists.linaro.org
> Subject: Suspected SPAM - [lng-odp] [API-NEXT PATCH] validation: pktio:
> remove CRCs from parser test packets
> 
> Remove precalculated CRCs from test packets. Some pktio devices may drop
> CRCs causing the tests to fail.
> 
> Signed-off-by: Matias Elo <matias....@nokia.com>
> ---
>  test/common_plat/validation/api/pktio/parser.h | 24 ++++++++++++---------
> ---
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/test/common_plat/validation/api/pktio/parser.h
> b/test/common_plat/validation/api/pktio/parser.h
> index 57c6238..5cc2b98 100644
> --- a/test/common_plat/validation/api/pktio/parser.h
> +++ b/test/common_plat/validation/api/pktio/parser.h
> @@ -28,6 +28,8 @@ int parser_suite_init(void);
>  /* test arrays: */
>  extern odp_testinfo_t parser_suite[];
> 
> +/* Test packets without CRC */
> +
>  /**
>   * ARP request
>   */
> @@ -39,7 +41,7 @@ static const uint8_t test_packet_arp[] = {
>       0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC0, 0xA8,
>       0x01, 0x02, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05,
>       0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D,
> -     0x0E, 0x0F, 0x10, 0x11, 0xA1, 0xA8, 0x27, 0x43,
> +     0x0E, 0x0F, 0x10, 0x11
>  };
> 
>  /**
> @@ -53,7 +55,7 @@ static const uint8_t test_packet_ipv4_icmp[] = {
>       0x01, 0x02, 0x00, 0x00, 0xB7, 0xAB, 0x00, 0x01,
>       0x00, 0x02, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05,
>       0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D,
> -     0x0E, 0x0F, 0x10, 0x11, 0xD9, 0x7F, 0xE8, 0x02,
> +     0x0E, 0x0F, 0x10, 0x11
>  };
> 
>  /**
> @@ -67,7 +69,7 @@ static const uint8_t test_packet_ipv4_tcp[] = {
>       0x01, 0x01, 0x04, 0xD2, 0x10, 0xE1, 0x00, 0x00,
>       0x00, 0x01, 0x00, 0x00, 0x00, 0x02, 0x50, 0x00,
>       0x00, 0x00, 0x0C, 0xCC, 0x00, 0x00, 0x00, 0x01,
> -     0x02, 0x03, 0x04, 0x05, 0x2E, 0xDE, 0x5E, 0x48,
> +     0x02, 0x03, 0x04, 0x05
>  };
> 
>  /**
> @@ -81,7 +83,7 @@ static const uint8_t test_packet_ipv4_udp[] = {
>       0x01, 0x01, 0x00, 0x3F, 0x00, 0x3F, 0x00, 0x1A,
>       0x2F, 0x97, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05,
>       0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D,
> -     0x0E, 0x0F, 0x10, 0x11, 0x64, 0xF4, 0xE4, 0xB6,
> +     0x0E, 0x0F, 0x10, 0x11
>  };
> 
>  /**
> @@ -96,7 +98,7 @@ static const uint8_t test_packet_vlan_ipv4_udp[] = {
>       0x01, 0x02, 0xC4, 0xA8, 0x01, 0x01, 0x00, 0x3F,
>       0x00, 0x3F, 0x00, 0x16, 0x4D, 0xBF, 0x00, 0x01,
>       0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09,
> -     0x0A, 0x0B, 0x0C, 0x0D, 0xCB, 0xBF, 0xD0, 0x29,
> +     0x0A, 0x0B, 0x0C, 0x0D
>  };
> 
>  /**
> @@ -112,7 +114,7 @@ static const uint8_t test_packet_vlan_qinq_ipv4_udp[]
> = {
>       0xF3, 0x73, 0xC0, 0xA8, 0x01, 0x02, 0xC4, 0xA8,
>       0x01, 0x01, 0x00, 0x3F, 0x00, 0x3F, 0x00, 0x12,
>       0x63, 0xDF, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05,
> -     0x06, 0x07, 0x08, 0x09, 0x80, 0x98, 0xB8, 0x18,
> +     0x06, 0x07, 0x08, 0x09
>  };
> 
>  /**
> @@ -126,8 +128,7 @@ static const uint8_t test_packet_ipv6_icmp[] = {
>       0x09, 0xFF, 0xFE, 0x00, 0x04, 0x00, 0x35, 0x55,
>       0x55, 0x55, 0x66, 0x66, 0x66, 0x66, 0x77, 0x77,
>       0x77, 0x77, 0x88, 0x88, 0x88, 0x88, 0x80, 0x00,
> -     0x1B, 0xC2, 0x00, 0x01, 0x00, 0x02, 0xE0, 0x68,
> -     0x0E, 0xBA,
> +     0x1B, 0xC2, 0x00, 0x01, 0x00, 0x02
>  };
> 
>  /**
> @@ -143,7 +144,7 @@ static const uint8_t test_packet_ipv6_tcp[] = {
>       0x77, 0x77, 0x88, 0x88, 0x88, 0x88, 0x04, 0xD2,
>       0x10, 0xE1, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00,
>       0x00, 0x02, 0x50, 0x00, 0x00, 0x00, 0x36, 0x37,
> -     0x00, 0x00, 0x28, 0x67, 0xD2, 0xAF,
> +     0x00, 0x00
>  };
> 
>  /**
> @@ -157,8 +158,7 @@ static const uint8_t test_packet_ipv6_udp[] = {
>       0x09, 0xFF, 0xFE, 0x00, 0x04, 0x00, 0x35, 0x55,
>       0x55, 0x55, 0x66, 0x66, 0x66, 0x66, 0x77, 0x77,
>       0x77, 0x77, 0x88, 0x88, 0x88, 0x88, 0x00, 0x3F,
> -     0x00, 0x3F, 0x00, 0x08, 0x9B, 0x68, 0x35, 0xD3,
> -     0x64, 0x49,
> +     0x00, 0x3F, 0x00, 0x08, 0x9B, 0x68
>  };
> 
>  /**
> @@ -174,7 +174,7 @@ static const uint8_t test_packet_vlan_ipv6_udp[] = {
>       0x04, 0x00, 0x35, 0x55, 0x55, 0x55, 0x66, 0x66,
>       0x66, 0x66, 0x77, 0x77, 0x77, 0x77, 0x88, 0x88,
>       0x88, 0x88, 0x00, 0x3F, 0x00, 0x3F, 0x00, 0x08,
> -     0x9B, 0x68, 0xC5, 0xD8, 0x2F, 0x5C,
> +     0x9B, 0x68
>  };
> 
>  #endif
> --
> 2.7.4

Reply via email to