On Fri, Apr 7, 2017 at 4:54 AM, Janne Peltonen <janne.pelto...@nokia.com> wrote:
>
> Update ABI spec with the new IPsec event type.
>
> Signed-off-by: Janne Peltonen <janne.pelto...@nokia.com>

Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org>

> ---
>  include/odp/arch/default/api/abi/event.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/odp/arch/default/api/abi/event.h 
> b/include/odp/arch/default/api/abi/event.h
> index ab14157..87220d6 100644
> --- a/include/odp/arch/default/api/abi/event.h
> +++ b/include/odp/arch/default/api/abi/event.h
> @@ -29,7 +29,8 @@ typedef enum odp_event_type_t {
>         ODP_EVENT_PACKET       = 2,
>         ODP_EVENT_TIMEOUT      = 3,
>         ODP_EVENT_CRYPTO_COMPL = 4,
> -       ODP_EVENT_IPSEC_RESULT = 5
> +       ODP_EVENT_IPSEC_RESULT = 5,
> +       ODP_EVENT_IPSEC_STATUS = 6

It's perfectly legal C for the last element in an enum to be
comma-terminated and that makes it easier to keep extending the enum
with additional entries since the previous entry doesn't have to keep
being modified to add a comma, so I'd suggest adopting that convention
here. Other than that nit, this looks fine.

>  } odp_event_type_t;
>
>  /**
> --
> 2.5.0
>

Reply via email to