>From test/common_plat/validation/api/scheduler/scheduler.c
#define BUFS_PER_QUEUE_EXCL 10000
The scalable scheduler has a default queue size of 4096 which seemed
reasonable to us. We can always increase the value but applications and
test prorgams should not expect infinite queue size. Perhaps scheduler.c
should create the queues with the queue size it is going to need? The test
will then verify that you can actually enqueue that many events on the
queue.
This test program also seems to create queues that are not destroyed. Is
that OK?
q = odp_queue_create(name, &p);
if (q == ODP_QUEUE_INVALID) {
printf("Schedule queue create failed.\n");
return -1;
}
snprintf(name, sizeof(name), "sched_%d_%d_a", i, j);
p.sched.sync = ODP_SCHED_SYNC_ATOMIC;
q = odp_queue_create(name, &p);
Reuse 'q' without destroying the queue created earlier.
On 7 April 2017 at 09:28, Kevin Wang <[email protected]> wrote:
> In the scalable scheduler, queue is implemented by the ring buffer.
> It is possible enqueue would fail if the ring buffer is full.
> So just remove the assert() check.
>
> Signed-off-by: Kevin Wang <[email protected]>
> ---
> test/common_plat/validation/api/scheduler/scheduler.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/test/common_plat/validation/api/scheduler/scheduler.c
> b/test/common_plat/validation/api/scheduler/scheduler.c
> index 952561c..e7623b7 100644
> --- a/test/common_plat/validation/api/scheduler/scheduler.c
> +++ b/test/common_plat/validation/api/scheduler/scheduler.c
> @@ -959,7 +959,6 @@ static void fill_queues(thread_args_t *args)
> }
>
> ret = odp_queue_enq(queue, ev);
> - CU_ASSERT_FATAL(ret == 0);
>
> if (ret)
> odp_buffer_free(buf);
> --
> 2.7.4
>
>
