Brian, can you please resend all patches as new version of patch set. Not embed them into current email thread. I think it will be more easy for second review.
Maxim. On 04.04.2017 21:48, Brian Brooks wrote: > Remove erroneous assertion that is handled in later code > > Signed-off-by: Kevin Wang <kevin.w...@arm.com> > Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> > --- > test/common_plat/validation/api/scheduler/scheduler.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/test/common_plat/validation/api/scheduler/scheduler.c > b/test/common_plat/validation/api/scheduler/scheduler.c > index 952561cd..bc486192 100644 > --- a/test/common_plat/validation/api/scheduler/scheduler.c > +++ b/test/common_plat/validation/api/scheduler/scheduler.c > @@ -251,7 +251,10 @@ void scheduler_test_queue_destroy(void) > CU_ASSERT_FATAL(u32[0] == MAGIC); > > odp_buffer_free(buf); > - odp_schedule_release_ordered(); > + if (qp.sched.sync == ODP_SCHED_SYNC_ATOMIC) > + odp_schedule_release_atomic(); > + else if (qp.sched.sync == ODP_SCHED_SYNC_ORDERED) > + odp_schedule_release_ordered(); > > CU_ASSERT_FATAL(odp_queue_destroy(queue) == 0); > } > @@ -478,6 +481,11 @@ void scheduler_test_groups(void) > odp_schedule_group_leave(mygrp1, &mymask); > odp_schedule_group_leave(mygrp2, &mymask); > > + if (qp.sched.sync == ODP_SCHED_SYNC_ATOMIC) > + odp_schedule_release_atomic(); > + else if (qp.sched.sync == ODP_SCHED_SYNC_ORDERED) > + odp_schedule_release_ordered(); > + > /* Done with queues for this round */ > CU_ASSERT_FATAL(odp_queue_destroy(queue_grp1) == 0); > CU_ASSERT_FATAL(odp_queue_destroy(queue_grp2) == 0); > @@ -959,7 +967,6 @@ static void fill_queues(thread_args_t *args) > } > > ret = odp_queue_enq(queue, ev); > - CU_ASSERT_FATAL(ret == 0); > > if (ret) > odp_buffer_free(buf); >
