On Fri, Apr 21, 2017 at 8:20 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote:
> These doxygen fixes look OK, but where is patch 5/6. First version had 5 > patches, this should have 6, but has only 5... Did something go wrong. > The first patch was written against master, but then I realized since it was making API changes (albeit just doxygen) that it should be against api-next. V2 is against api-next and since that includes another API file (ipsec.h) that also needed updating v2 is in 6 parts. v2 is the one that should be merged and then it can be pulled forward to master. > > -Petri > > > > -----Original Message----- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Bill > > Fischofer > > Sent: Thursday, April 20, 2017 1:35 AM > > To: lng-odp@lists.linaro.org > > Subject: [lng-odp] [API-NEXT PATCHv2 6/6] helper: add additional doxygen > > documentation > > > > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding > > additional field documentation to avoid problems with doxygen 1.8.13 > > and higher. > > > > Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> > > --- > > helper/include/odp/helper/icmp.h | 11 ++++++---- > > helper/include/odp/helper/ip.h | 2 +- > > helper/include/odp/helper/strong_types.h | 3 ++- > > helper/include/odp/helper/table.h | 2 +- > > helper/include/odp/helper/tcp.h | 35 > ++++++++++++++++----------- > >
