All good points. There's more subtly going on than I originally realized. I've added this to the agenda for today's public call.
On Tue, Apr 25, 2017 at 5:59 AM, Ola Liljedahl <ola.liljed...@arm.com> wrote: > > On 25/04/2017, 12:54, "Savolainen, Petri (Nokia - FI/Espoo)" > <petri.savolai...@nokia-bell-labs.com> wrote: > > >Also in your patch, thread should exit only after scheduler returns > >EVENT_INVALID. > >Since the cool_down event is the last event on all queues (as they are > >enqueued after all threads have passed the barrier), when we have > >received all cool_down events we know that there are no other events on > >the these queues. No need to call odp_schedule() until it returns > >ODP_EVENT_INVALID (which can happen spuriously anyway so doesn't signify > >anything). > > > > > >It signifies release of the schedule context. For a robust exit, > >application should release the current context. > OK. Either odp_schedule() must have returned invalid event or we need an > explicit release call. > But you don¹t think this is something odp_term_local() should handle? > > > > >-Petri > > > > > >
