On 05/04/17 22:41, Bill Fischofer wrote: > This seems overkill as having this in Travis is useful except for the > erroneous warnings we get. I've posted > patch http://patches.opendataplane.org/patch/8743/ to address the most > common issues we've been seeing of late. > > Worth giving that one a go before pulling the plug? >
I will check if it fixes some latest patches in api-next. Also I think maybe for CamelCase have some list of regexp functions which we accept like Cunit, SSL. And not all functions. Maxim. > On Thu, May 4, 2017 at 2:03 PM, Maxim Uvarov <maxim.uva...@linaro.org > <mailto:maxim.uva...@linaro.org>> wrote: > > Having checkpatch inside Travis job looks like a bad idea. > Or we need regularly fix checkpatch itself or ignore it's result. > I added checkpatch results to generated email from pull request > and also we can enable it in some other way. > > This reverts commit: > 39edf612 Revert "travis: add code style checks" > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org > <mailto:maxim.uva...@linaro.org>> > --- > .travis.yml | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index aa7ea010..bf72f722 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -101,21 +101,6 @@ before_install: > - popd > > script: > - - echo $TRAVIS_COMMIT_RANGE > - - ODP_PACHES=`echo $TRAVIS_COMMIT_RANGE | sed 's/\.//'` > -# Generate patches provided with $TRAVIS_COMMIT_RANGE. > -# In case of force push and range is broken validate only > the latest commit if it's not merge commit. > - - git format-patch $ODP_PACHES; > - if [ $? -ne 0 ]; then > - git show --summary HEAD| grep -q '^Merge:'; > - if [ $? -ne 0 ]; then > - git format-patch HEAD^; > - perl ./scripts/checkpatch.pl <http://checkpatch.pl> > *.patch; > - fi; > - else > - perl ./scripts/checkpatch.pl <http://checkpatch.pl> > *.patch; > - fi > - > - ./bootstrap > - ./configure > # doxygen does not trap on warnings, check for them here. > -- > 2.11.0.295.gd7dffce > >
