On 06/21/17 11:00, Github ODP bot wrote:
From: Yi He <yi...@linaro.org>

Make distcheck with all test configurations
to confirm test programs installation in odp
distribution package.

Signed-off-by: Yi He <yi...@linaro.org>
---
/** Email created from pull request 35 (heyi-linaro:install-check)
  ** https://github.com/Linaro/odp/pull/35
  ** Patch: https://github.com/Linaro/odp/pull/35.patch
  ** Base sha: 0d24adacfe17c8e0e1348f19cd8b75b64cb13ccf
  ** Merge commit sha: 98a29bbfe0330710e92fce70c7b3243bee460257
  **/
  .travis.yml | 2 +-
  Makefile.am | 9 ++++++---
  2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 50b3b9c2..95f30fee 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -136,7 +136,7 @@ jobs:
                    compiler: gcc
                    script:
                            - ./bootstrap
-                          - ./configure
+                          - ./configure --prefix=$HOME/odp-install 
--enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf 
--enable-user-guides --enable-test-perf-proc --enable-test-example
                            - sudo 
LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck
                  - stage: test
                    env: TEST=doxygen
diff --git a/Makefile.am b/Makefile.am
index daa49788..b43d1be6 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,8 +1,11 @@
  ACLOCAL_AMFLAGS=-I m4
  AUTOMAKE_OPTIONS = foreign
-AM_DISTCHECK_CONFIGURE_FLAGS = --enable-test-cpp \
-                              --enable-test-perf \
-                              --enable-test-vald \
+AM_DISTCHECK_CONFIGURE_FLAGS = --enable-test-cpp       \
+                              --enable-test-perf       \
+                              --enable-test-vald       \
+                              --enable-test-helper     \
+                              --enable-test-example    \
+                              --enable-test-perf-proc  \
                               --with-testdir


I think that is good to test all options for distribution. Only 2 comments:
1. travis changes better to do separate.
2. please do alphabetical order of that list.

does configure; make distcheck without options still work after that changes?

Maxim.



  #@with_platform@ works alone in subdir but not as part of a path???


Reply via email to