On 21.06.2017 23:08, Ola Liljedahl wrote: > > On 21/06/2017, 22:00, "Dmitry Eremin-Solenikov" > <dmitry.ereminsoleni...@linaro.org> wrote: > >> On 21.06.2017 21:14, Ola Liljedahl wrote: >>> >>> On 20/06/2017, 15:04, "Savolainen, Petri (Nokia - FI/Espoo)" >>> <petri.savolai...@nokia.com> wrote: >>> >>>> >>>> >>>>> +++ b/platform/linux-generic/include/odp_bitset.h >>>>> @@ -0,0 +1,210 @@ >>>>> +/* Copyright (c) 2017, ARM Limited >>>>> + * All rights reserved. >>>>> + * >>>>> + * SPDX-License-Identifier: BSD-3-Clause >>>>> + */ >>>>> + >>>>> +#ifndef _ODP_BITSET_H_ >>>>> +#define _ODP_BITSET_H_ >>>>> + >>>>> +#include <odp_cpu.h> >>>>> + >>>>> +#include <limits.h> >>>>> + >>>>> >>>>> >>>>> +/********************************************************************* >>>>> ** >>>>> * >>>>> ****** >>>>> + * bitset abstract data type >>>>> + >>>>> >>>>> >>>>> *********************************************************************** >>>>> ** >>>>> * >>>>> ***/ >>>>> +/* This could be a struct of scalars to support larger bit sets */ >>>>> + >>>>> +/* >>>>> + * Size of atomic bit set. This limits the max number of threads, >>>>> + * scheduler groups and reorder windows. On ARMv8/64-bit and x86-64, >>>>> the >>>>> + * (lock-free) max is 128 >>>>> + */ >>>>> + >>>>> +/* Find a suitable data type that supports lock-free atomic >>>>> operations >>>>> */ >>>>> +#if defined(__ARM_ARCH) && __ARM_ARCH == 8 && __ARM_64BIT_STATE == >>>>> 1 >>>>> && >>>> >>>> Why ifdef ARM? Why this code is not in arch directory ? >>> Why is this car red? >>> Because I like it like that. >> >> I think it was agreed that arch-specific code should go to arch/ dirs, >> wasn't it? > If you bend backwards enough, you will always touch ground again with your > hands. It doesn¹t mean it is meaningful to do so. Especially not when you > can just lean forward and accomplish the same without the pain.
Ola, sometimes it is necessary to bend backwards. -- With best wishes Dmitry
