Petri, are you ok with that serries? Patch 9/9 is the major goal for odp
packaging.

p.s. as for me I don't have objections to merge it.

Maxim.

On 4 July 2017 at 23:07, Dmitry Eremin-Solenikov <
dmitry.ereminsoleni...@linaro.org> wrote:

> On 04.07.2017 16:43, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> >
> >
> >> -----Original Message-----
> >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org
> ]
> >> Sent: Tuesday, July 04, 2017 3:16 PM
> >> To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>;
> >> Github ODP bot <odp...@yandex.ru>; lng-odp@lists.linaro.org
> >> Subject: Re: [lng-odp] [PATCH v4 3/9] linux-gen: stop poisoning
> >> CPPFLAGS/LDFLAGS with DPDK flags
> >>
> >> On 03.07.2017 13:34, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> >>>> diff --git a/test/Makefile.inc b/test/Makefile.inc
> >>>> index 1ef2a92c..bf31b374 100644
> >>>> --- a/test/Makefile.inc
> >>>> +++ b/test/Makefile.inc
> >>>> @@ -4,7 +4,7 @@ LIB   = $(top_builddir)/lib
> >>>>  #in the following line, the libs using the symbols should come before
> >>>>  #the libs containing them! The includer is given a chance to add
> >> things
> >>>>  #before libodp by setting PRE_LDADD before the inclusion.
> >>>> -LDADD = $(PRE_LDADD) $(LIB)/libodphelper.la $(LIB)/libodp-linux.la
> >>>> +LDADD = $(PRE_LDADD) $(LIB)/libodphelper.la $(LIB)/libodp-linux.la
> >>>> $(DPDK_PMDS)
> >>>
> >>> Application using ODP should only need to add dependency to ODP and
> >> helper libs. It's not scalable if (all) applications need to know which
> >> (all) libs an ODP implementation may use internally.
> >>>
> >>> I guess this solves some DPDK linking issues, but is there a way to
> >> avoid explicit dependency to ODP lib internals ?
> >>
> >> Just to rephrase/emphasize my answer: user applications will use
> >> pkg-config file, which contains all necessary data to link with DPDK w/o
> >> mentioning it specifically. The only issue is internal linking inside
> >> ODP or linking using libtool.
> >>
> >
> > In principle, our example/validation apps should see ODP the same way as
> any other app. That's why it seems odd that DPDK libs need to be exposed
> when linking those (or are those needed because of the test/linux-generic
> folder).
> >
> > My main concern is that external applications (like OFP) would need to
> add the same modification to their linking rules. That seems not to be the
> case, so I guess it's OK then.
>
> I understand that. In fact, my major concern when starting this PR was
> exactly linking of external apps. Check patch 9/9, which makes shure
> that one can use pkg-config to link ODP app instead of specifying all
> dependencies.
>
> --
> With best wishes
> Dmitry
>

Reply via email to