> -----Original Message----- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Thursday, July 06, 2017 11:00 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [API-NEXT PATCH 2/4] linux-gen: sched: use config > max ordered locks > > On 5 July 2017 at 01:35, Savolainen, Petri (Nokia - FI/Espoo) > <petri.savolai...@nokia.com> wrote: > > > >> > diff --git a/platform/linux-generic/include/odp_config_internal.h > >> b/platform/linux-generic/include/odp_config_internal.h > >> > index 3cff0045..469396df 100644 > >> > --- a/platform/linux-generic/include/odp_config_internal.h > >> > +++ b/platform/linux-generic/include/odp_config_internal.h > >> > @@ -27,7 +27,7 @@ > >> > /* > >> > * Maximum number of ordered locks per queue > >> > */ > >> > -#define CONFIG_QUEUE_MAX_ORD_LOCKS 4 > >> > +#define CONFIG_QUEUE_MAX_ORD_LOCKS 2 > >> > >> This is unnecessary change for this patch. This patch does not need > this > >> change. > > > > With this value (2), the current situation does not change. Internal > defines limited the number into 2, so this keeps it 2. > > This change affects other implementations of the scheduler. If the > default scheduler is implemented independent of what the value of > CONFIG_QUEUE_MAX_ORD_LOCKS is, this change is not required. > This change should not be necessary for this patch.
I try to keep properties as they were before the patch. I have not heard anybody complaining that 2 locks is not sufficient. Have you? We can later expand the value if needed. Your scheduler is not widely used yet (it's been in api-next a week or so), so people using this feature have not been exposed to number of locks being 4. It was 2, I keep it 2 and we can increase it later if someone needs a larger value. -Petri
