> -----Original Message----- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Friday, July 07, 2017 9:28 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [API-NEXT PATCH 1/4] linux-gen: sched: remove > schedule interface depedency to qentry > > On 7 July 2017 at 01:46, Savolainen, Petri (Nokia - FI/Espoo) > <petri.savolai...@nokia.com> wrote: > >> >> typedef struct schedule_fn_t { > >> >> + int status_sync; > >> > > >> > this structure should contain functions that are provided by > scheduler > >> > to other components of ODP. 'status_sync' seems to be an internal > >> > mechanism between the default scheduler and default queue. Hence it > >> > should not be here. > >> > > >> Any update on this comment? > > > > I did answer it already. > > Ok, found your answer. Should this variable be moved to queue internal > structure which is set only for iQuery scheduler? > > This structure should contain only the functions exposed by the > scheduler to other components of ODP. It should not contain anything > related to the interface between queue and scheduler (they are being > considered as a single module).
These functions are called from queue, so it's queue -> iquery interface (scheduler interface, not queue interface). These functions can be removed (if iquery is not anymore maintained) or moved as a next step, but that's out of scope of this patch set. This set simply removes unused functions and minimizes number of functions calls, but does not move functions from one (interface) file to another. This set removes dependency to those iquery specific functions already from all other code except queue and iquery, so removing / moving those is easier after this is merged. -Petri
