Merged.
On 07/20/2017 08:15 PM, Brian Brooks wrote:
On 07/27 14:04:24, Maxim Uvarov wrote:
Looks like everything is fine:
https://github.com/Linaro/odp/pull/71
Brian do you want to add your review to final patch? If no more objection
I'm merging this and will work on merging other patches in the queue.
For ca08c5c810, Signed-off-by: Brian Brooks <brian.bro...@arm.com>
Maxim.
On 26 July 2017 at 22:33, Maxim Uvarov <maxim.uva...@linaro.org> wrote:
Updated pull request. Let's see what test will show.
Maxim.
On 07/26/17 22:19, Dmitry Eremin-Solenikov wrote:
On 26/07/17 22:04, Bill Fischofer wrote:
I guess another question is why doesn't this issue show up in api-next
without this patch series or in master by itself?
Because we do not (yet) have cross-compilation testing in api-next in
Travis. And master branch doesn't have this code also.
On Wed, Jul 26, 2017 at 1:55 PM, Dmitry Eremin-Solenikov
<dmitry.ereminsoleni...@linaro.org
<mailto:dmitry.ereminsoleni...@linaro.org>> wrote:
Brian,
On 20 July 2017 at 00:23, Brian Brooks <brian.bro...@arm.com
<mailto:brian.bro...@arm.com>> wrote:
> On 07/26 10:29:41, Dmitry Eremin-Solenikov wrote:
>> On 26/07/17 01:00, Maxim Uvarov wrote:
>> > Merge request is:
>> >
>> > https://github.com/Linaro/odp/pull/71
<https://github.com/Linaro/odp/pull/71>
>> >
>> > 2 arm build fails with errors.
>>
>> Both are due to scalable scheduler code.
>
> Neither are due to scalable scheduler. They are actually due to
compiling
> an ARMv8 instruction into the binary when the compiler is
targeting ARMv7a.
Sorry, this looked to me like the code that went in with the
scheduler. Please
excuse me.
> I suggest we enable CONFIG_WFE only for ARMv8:
Hmm. Wasn't this code also tested for ARMv7?
> diff --git a/platform/linux-generic/arch/arm/odp_cpu.h
b/platform/linux-generic/arch/arm/odp_cpu.h
> index 8ef50da4..72c81020 100644
> --- a/platform/linux-generic/arch/arm/odp_cpu.h
> +++ b/platform/linux-generic/arch/arm/odp_cpu.h
> @@ -38,7 +38,9 @@
> * more scalable) and enables the CPU to enter a sleep state
(lower power
> * consumption).
> */
> +#ifdef __aarch64__
> #define CONFIG_WFE
> +#endif
>
> static inline void dmb(void)
> {
>
> Can you test with this?
I did not test it, but hopefully it should fix the issue.
>
>> >
>> > 1.
>> >
>> > https://travis-ci.org/muvarov/odp/jobs/257478037
<https://travis-ci.org/muvarov/odp/jobs/257478037>
>> > CC odp_rwlock.lo
>> > <inline asm>:1:2: error: instruction requires: armv8
>> > sevl
>> >
>> > 2.
>> >
>> > https://travis-ci.org/muvarov/odp/jobs/257478036
<https://travis-ci.org/muvarov/odp/jobs/257478036>
>> > CC odp_schedule.lo
>> > /tmp/ccRdUDmO.s: Assembler messages:
>> > /tmp/ccRdUDmO.s:1281: Error: selected processor does not
support Thumb
>> > mode `sevl'
>> > /tmp/ccRdUDmO.s:2306: Error: selected processor does not
support Thumb
>> > mode `sevl'
>> > /tmp/ccRdUDmO.s:2481: Error: selected processor does not
support Thumb
>> > mode `sevl'
>> > /tmp/ccRdUDmO.s:3217: Error: selected processor does not
support Thumb
>> > mode `sevl'
>> > /tmp/ccRdUDmO.s:3635: Error: selected processor does not
support Thumb
>> > mode `sevl'
>> > /tmp/ccRdUDmO.s:3873: Error: selected processor does not
support Thumb
>> > mode `sevl'
>> > make[1]: *** [odp_queue_scalable.lo] Error 1
>> > make[1]: *** Waiting for unfinished jobs....
>> > make[1]: Leaving directory
>> > `/home/travis/build/muvarov/odp/platform/linux-generic'
>> > make: *** [all-recursive] Error 1
--
With best wishes
Dmitry
