HI Maxim So that I can better take care of problem raised below, help me to understand this.
Currently I have two commits in my local branch :1st-as of today, 2nd: older commit having older spec version (already pushed to branch and pull request v1 raised on it). So, before I push it to my pull request branch, do I need to squash them ? Or just push will do.? As I understand, current push should generate v2 with latest commit log and it should just suffice. Thanks Shally From: Shally Verma [mailto:notificati...@github.com] Sent: 31 August 2017 14:00 To: Linaro/odp <o...@noreply.github.com> Cc: Verma, Shally <shally.ve...@cavium.com>; Your activity <your_activ...@noreply.github.com> Subject: Re: [Linaro/odp] [PATCH API-NEXT v12] comp: compression spec (#102) Yea I realise that part and I tried to squash them however since I am new to github so taking more time with all this. I am trying to understand how best to resolve them and make it one smooth flow until then, Please bear with me on these issues. If Maxim (or any other) don’t mind to share his chat ID to me, then I can work with him and get past these issues fast. Thanks Shally From: Petri Savolainen [mailto:notificati...@github.com] Sent: 31 August 2017 13:54 To: Linaro/odp <o...@noreply.github.com> Cc: Verma, Shally <shally.ve...@cavium.com>; Mention <ment...@noreply.github.com> Subject: Re: [Linaro/odp] [PATCH API-NEXT v12] comp: compression spec (#102) There should be only one API spec commit. It seems now that there are 6 commits. Please, squash all commits into one. It's pretty much impossible to review / comment this spec now. Change commit subject to "api: comp: introduce compression API". All API spec file changing commits MUST start with "api: " prefix. It seems that commit log text is empty. It should have rationale for the change. In this case describe the intended usage on the new API, etc. E.g. 5 sentences of text what problem comp API solves, for what problem application should use it, etc. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/Linaro/odp/pull/102#issuecomment-326226266>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIFXaHsw4hvMg50u0bvFvbZgtwPHLcJ4ks5sdm2pgaJpZM4Oq6xH>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://github.com/Linaro/odp/pull/102#issuecomment-326227683>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIFXaFU8ZmoXCJD9dS3-6eylmlvplzKZks5sdm8IgaJpZM4Oq6xH>.
