----------------github------------------------ /** Email created from pull request 166 (brbrooks:cloud-dev) ** https://github.com/Linaro/odp/pull/166 ** Patch: https://github.com/Linaro/odp/pull/166.patch ** Base sha: d3fe76f2af39af17a3661b866a442878abc31ddc ** Merge commit sha: 306bdb45117f6891f18ad9c540f94fa9aa54123c **/ ----------------/github------------------------
----------------checkpatch.pl------------------------ WARNING: Avoid unnecessary line continuations #138: FILE: platform/linux-generic/include/odp_schedule_subsystem.h:68: + odp_api_proto(schedule, schedule_release_atomic) \ WARNING: Avoid unnecessary line continuations #140: FILE: platform/linux-generic/include/odp_schedule_subsystem.h:70: + odp_api_proto(schedule, schedule_release_ordered) \ total: 0 errors, 2 warnings, 0 checks, 124 lines checked to_send-p-000.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: externs should be avoided in .c files #297: FILE: platform/linux-generic/odp_schedule_if.c:11: +extern const schedule_fn_t schedule_scalable_fn; WARNING: externs should be avoided in .c files #298: FILE: platform/linux-generic/odp_schedule_if.c:12: +extern const schedule_fn_t schedule_default_fn; WARNING: please, no space before tabs #576: FILE: platform/linux-generic/schedule/scalable.c:1966: +^I.wait_time^I ^I= schedule_wait_time,$ total: 0 errors, 3 warnings, 0 checks, 685 lines checked to_send-p-001.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 0 checks, 371 lines checked to_send-p-002.patch has no obvious style problems and is ready for submission. ----------------/checkpatch.pl------------------------