Petri Savolainen(psavol) replied on github web page:

include/odp/api/spec/packet_io.h
line 17
@@ -256,11 +256,27 @@ typedef struct odp_pktio_param_t {
  * belong to time synchronization protocol (PTP).
  *
  * Packet input checksum checking may be enabled or disabled. When it is
- * enabled, implementation will verify checksum correctness on incoming packets
- * and depending on drop configuration either deliver erroneous packets with
- * appropriate flags set (e.g. odp_packet_has_l3_error()) or drop those.
- * When packet dropping is enabled, application will never receive a packet
- * with the specified error and may avoid to check the error flag.
+ * enabled, implementation will attempt to verify checksum correctness on
+ * incoming packets and depending on drop configuration either deliver 
erroneous
+ * packets with appropriate flags set (e.g. odp_packet_has_l3_error(),
+ * odp_packet_l3_chksum_status()) or drop those. When packet dropping is
+ * enabled, application will never receive a packet with the specified error
+ * and may avoid to check the error flag.
+ *
+ * If checksum checking is enabled, IPv4 header checksum checking is always
+ * done for packets that do not have IP options and L4 checksum checking


Comment:
Basic IP packets checksum checking is a MUST, support for options is a MAY.

We don't want to force every implementation to check also packets with IP 
options, since not all HW can do it. User finds out if the check was done from 
the packet. 

https://github.com/Linaro/odp/pull/167#discussion_r137495751
updated_at 2017-09-07 09:53:12

Reply via email to