Dmitry Eremin-Solenikov(lumag) replied on github web page:

shippable.yml
line 14
@@ -0,0 +1,45 @@
+language: c
+
+compiler:
+  - gcc
+  - clang
+
+env:
+  matrix:
+    - CONF=""
+    # - CONF="--disable-abi-compat"
+    # - CONF="--enable-schedule-sp"
+    # - CONF="--enable-schedule-iquery"
+    # - CONF="--enable-dpdk-zero-copy"
+    - CROSS_ARCH="arm64"


Comment:
@ttrahan @muvarov ATM this uncomented CROSS_ARCH lines does not make sense. I'd 
prefer to see it commented, so that there are no extra builds in Shippable.

> muvarov wrote
> yep, I agree to have it as it now. We need to make some simple run. Then 
> extend it. It will be nice if we can have common file for Shippable and 
> Travis or generate them from some common template. But that can be later.


>> Tom Trahan(ttrahan) wrote:
>> My understanding is that this shippable.yml will evolve shortly to perform 
>> the same build functionality in the .travis.yml config, including the 
>> cross-arch testing. This is simply the initial build sample to start with a 
>> simple example, that will then proceed to add in the additional tests. As 
>> such, I suggest leaving this in as a placeholder for these next steps.


>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>> It seems there is a confusion here. Currently this setup generates 4 build 
>>> jobs (2 for CONF setting, 2 for CROSS_ARCH). There is no need to run 
>>> CROSS_ARCH jobs (and it is not a cross-build anyway). Let's drop CROSS_ARCH 
>>> settings altogether.


>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>> Replace with `sudo env ODP_SHM_DIR=/dev/shm/odp make check`


>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>> Also you can drop these two lines. Again, CUnit handling


>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>> ```diff
>>>>>> + libcunit1-dev \
>>>>>> ```


>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>> This whole block (lines 38--46) is a part of CUnit handling and so 
>>>>>>> should be dropped


>>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>>> This should not be necessary. Ubuntu 16.04 already provides CUnit 
>>>>>>>> 2.1-3. So it is better to use system one.


>>>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>>>> Please use command from updated .travis.yml


>>>>>>>>>> muvarov wrote
>>>>>>>>>> Coverity I also thing should go away. This script does not send 
>>>>>>>>>> results to Coverity.


>>>>>>>>>>> muvarov wrote
>>>>>>>>>>> this needs to be alphabetic sorted.


https://github.com/Linaro/odp/pull/231#discussion_r145919503
updated_at 2017-10-20 09:39:19

Reply via email to