Hi Petri there's no check on snprintf regarding the returned len. Is there any 
possibility in this code that the final buffer will be bigger than max_len?
—


I calculate max string len from number of bytes to print:

int num_rows = (byte_len + bytes_per_row - 1) / bytes_per_row;
int max_len = 256 + (3 * byte_len) + (3 * num_rows);


As long as the math is right the buffer size is larger than the string. The 
same snprintf code is used in the current odp_packet_print().

-Petri

Reply via email to