Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:

platform/linux-generic/Makefile.am
line 49
@@ -354,20 +347,31 @@ endif
 
 pool/generic.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE
 buffer/generic.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE
+
 if ODP_SCHEDULE_SCALABLE
+__LIB__libodp_linux_la_SOURCES += schedule/scalable.c \
+                                 schedule/scalable_ordered.c
 schedule/scalable.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE
 else
-schedule/generic.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE
-endif
 if ODP_SCHEDULE_SP
+__LIB__libodp_linux_la_SOURCES += schedule/sp.c
 schedule/sp.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE
-endif
+else
 if ODP_SCHEDULE_IQUERY
+__LIB__libodp_linux_la_SOURCES += schedule/iquery.c
 schedule/iquery.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE
+else
+__LIB__libodp_linux_la_SOURCES += schedule/generic.c
+schedule/generic.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE
+endif
 endif
+endif
+
 if ODP_SCHEDULE_SCALABLE
+__LIB__libodp_linux_la_SOURCES += queue/scalable.c
 queue/scalable.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE
 else
+__LIB__libodp_linux_la_SOURCES += queue/generic.c
 queue/generic.lo: AM_CFLAGS += -DIM_ACTIVE_MODULE


Comment:
Same comment as above. Not relevant to this PR's subject matter.

> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> Again it's not obvious how these are buffer changes.


>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> What do these changes have to do with the subject of this PR? Changes to 
>> Travis should at minimum be a separate commit (these are not "linux-generic: 
>> buffer" changes) and should probably be a separate PR with its own rationale.


https://github.com/Linaro/odp/pull/266#discussion_r147884000
updated_at 2017-10-31 02:50:18

Reply via email to