Dmitry Eremin-Solenikov(lumag) replied on github web page: include/odp/api/spec/crypto.h line 8 @@ -90,7 +90,10 @@ typedef enum { ODP_DEPRECATE(ODP_CIPHER_ALG_AES128_CBC), /** @deprecated Use ODP_CIPHER_ALG_AES_GCM instead */ - ODP_DEPRECATE(ODP_CIPHER_ALG_AES128_GCM) + ODP_DEPRECATE(ODP_CIPHER_ALG_AES128_GCM), + + /** AES with counter mode */ + ODP_CIPHER_ALG_AES_CTR,
Comment: Doing so would break binary compatibility. Is it ok? > Petri Savolainen(psavol) wrote: > Same here, move upwards. On top of deprecated. >> Petri Savolainen(psavol) wrote: >> I'd move this after AES_CBC or AES_GCM. It's easier to see what's deprecated >> when those are on the bottom. https://github.com/Linaro/odp/pull/271#discussion_r148797902 updated_at 2017-11-03 14:32:48