Petri Savolainen(psavol) replied on github web page:
test/performance/odp_l2fwd.c
line 5
@@ -108,6 +108,7 @@ typedef struct {
int error_check; /**< Check packet errors */
int sched_mode; /**< Scheduler mode */
int num_groups; /**< Number of scheduling groups */
+ int verbose; /**< Verbose output */
} appl_args_t;
Comment:
I used this option to check the frame sizes. E.g. dpdk pktio returned IP MTU
size (1500), not max ethernet frame size (1514). This an easy way to check it
on various pktios as l2fwd takes interface as a command line parameter.
> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> It's not obvious what these changes have to do with the stated purpose of
> this PR. This looks like a separate PR altogether.
>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> This seems a worthwhile cleanup but seems orthogonal to the rest of this PR.
>>> muvarov wrote
>>> @psavol then I'm ok.
>>>> Petri Savolainen(psavol) wrote:
>>>> int odp_pktin_event_queue(odp_pktio_t pktio, odp_queue_t queues[], int
>>>> num);
>>>> int odp_pktin_queue(odp_pktio_t pktio, odp_pktin_queue_t queues[], int
>>>> num);
>>>> uint64_t odp_pktin_wait_time(uint64_t nsec);
>>>> uint64_t odp_pktin_ts_res(odp_pktio_t pktio);
>>>> odp_time_t odp_pktin_ts_from_ns(odp_pktio_t pktio, uint64_t ns);
>>>>
>>>> These are not the first pktin/pkout functions that have pktio as param.
>>>> Previously, I considered odp_pktio_rx_xxx() and odp_pktio_tx_xxx()
>>>> prefixes for these, but odp_pktin_xxx() and odp_pktout_xxx() was more
>>>> compact and as intuitive.
>>>>
>>>> Also these are not capabilities but the current configured frame lengths.
>>>> Later on, we'll add configuration options for changing these and
>>>> capabilities to indicate min/max values. This is now a simple replacement
>>>> of MTU function.
>>>>> muvarov wrote
>>>>> bad naming. odp_pktin_xxx functions take argument odp_pktin_queue_t not
>>>>> odp_pktio_t. If you want to keep odp_pktio_t as argument for function,
>>>>> then odp_pktio_capability_t is more logical place for it,
https://github.com/Linaro/odp/pull/298#discussion_r151921265
updated_at 2017-11-20 08:00:57
