Dmitry Eremin-Solenikov(lumag) replied on github web page: test/common/odp_cunit_common.c line 17 @@ -7,13 +8,15 @@ #include "config.h" #include <string.h> +#include <unistd.h> #include <odp_api.h> #include "odp_cunit_common.h" #include <odp/helper/odph_api.h> /* Globals */ static odph_odpthread_t thread_tbl[MAX_WORKERS]; static odp_instance_t instance; +extern const char *__progname;
Comment: @muvarov yes > muvarov wrote > yep, thanks it's copy paste text >> muvarov wrote >> save argv[0] in some global variable? >>> Dmitry Eremin-Solenikov(lumag) wrote: >>> This looks like an overkill. I'd suggest to use Autoconf variable rather >>> than Automake conditional here. >>>> Dmitry Eremin-Solenikov(lumag) wrote: >>>> This is just incorrect >>>>> Dmitry Eremin-Solenikov(lumag) wrote: >>>>> This should be refactored to a function which is selected basing on >>>>> `TEST_CUNIT_XML`, rather than having `#ifdef` directly in the function >>>>> body. >>>>>> Dmitry Eremin-Solenikov(lumag) wrote: >>>>>> Please use a copy of `argv[0]` instead of progname. https://github.com/Linaro/odp/pull/309#discussion_r153518159 updated_at 2017-11-28 15:04:21
