Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/m4/odp_dpdk.m4
@@ -5,9 +5,21 @@ pktio_dpdk_support=no
AC_ARG_WITH([dpdk-path],
[AS_HELP_STRING([--with-dpdk-path=DIR], [path to dpdk build directory])],
[DPDK_PATH="$withval"
+ pktio_dpdk_support=yes],[])
+
+if test "x$DPDK_PATH" = "xsystem" ; then
Comment:
I would suggest going forward with this approach (two separate flags).
If the user only gives '--with-dpdk-path= PATH_TO_DPDK' flag, you can
presumably handle this in the configure script (so that only one flag has to be
used).
> Dmitry Eremin-Solenikov(lumag) wrote:
> ack
>> Dmitry Eremin-Solenikov(lumag) wrote:
>> Good question. For more or less typical case (non-system DPDK) this would
>> require adding two flags (`--enable-dpdk-support
>> --with-dpdk-path=PATH_TO_DPDK`).
>>> Matias Elo(matiaselo) wrote:
>>> uintptr_t would be a more suitable type here.
>>>> Matias Elo(matiaselo) wrote:
>>>> If I understood this correctly, a user would have to use
>>>> '--with-dpdk-path=system' configure option for this to work. Wouldn't a
>>>> more standard way of doing this be to add e.g. '--enable-dpdk-support'
>>>> flag in the same manner as with netmap pktio?
https://github.com/Linaro/odp/pull/321#discussion_r154651878
updated_at 2017-12-04 13:48:41
