Matias Elo(matiaselo) replied on github web page: platform/linux-generic/pktio/dpdk.c line 24 @@ -29,14 +29,27 @@ #include <rte_config.h> #include <rte_malloc.h> +#if __GNUC__ >= 7 +#pragma GCC diagnostic push +#pragma GCC diagnostic warning "-Wimplicit-fallthrough=0" +#endif #include <rte_mbuf.h> +#if __GNUC__ >= 7 +#pragma GCC diagnostic pop +#endif #include <rte_mempool.h> #include <rte_ethdev.h> #include <rte_ip.h> #include <rte_ip_frag.h> +#include <rte_log.h> #include <rte_udp.h> #include <rte_tcp.h> #include <rte_string_fns.h> +#include <rte_version.h> + +#if RTE_VERSION < RTE_VERSION_NUM(17, 8, 0, 0) +#define rte_log_set_global_level rte_set_log_level +#endif
Comment: This breaks build on Ubuntu 17.10, which uses DPDK 17.05: 'error: ârte_set_log_levelâ is deprecated' So the correct version to use here is RTE_VERSION_NUM(17, 5, 0, 0) > Matias Elo(matiaselo) wrote: > I would suggest going forward with this approach (two separate flags). > > If the user only gives '--with-dpdk-path= PATH_TO_DPDK' flag, you can > presumably handle this in the configure script (so that only one flag has to > be used). >> Dmitry Eremin-Solenikov(lumag) wrote: >> ack >>> Dmitry Eremin-Solenikov(lumag) wrote: >>> Good question. For more or less typical case (non-system DPDK) this would >>> require adding two flags (`--enable-dpdk-support >>> --with-dpdk-path=PATH_TO_DPDK`). >>>> Matias Elo(matiaselo) wrote: >>>> uintptr_t would be a more suitable type here. >>>>> Matias Elo(matiaselo) wrote: >>>>> If I understood this correctly, a user would have to use >>>>> '--with-dpdk-path=system' configure option for this to work. Wouldn't a >>>>> more standard way of doing this be to add e.g. '--enable-dpdk-support' >>>>> flag in the same manner as with netmap pktio? https://github.com/Linaro/odp/pull/321#discussion_r155495549 updated_at 2017-12-07 11:26:55
