From: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Converting programming error checks to ODP_ASSERT, saves cycles and space on the cache line.
Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Kevin Wang <kevin.w...@arm.com> Reviewed-by: Yi He <yi...@arm.com> --- /** Email created from pull request 346 (nagarahalli:cp-pad-pool-cache) ** https://github.com/Linaro/odp/pull/346 ** Patch: https://github.com/Linaro/odp/pull/346.patch ** Base sha: bbbe6c0ef65c16f6d7d327712f177fbf6740e96f ** Merge commit sha: c453edadb1e6f0cfbe31e17432d4f046d0511a05 **/ platform/linux-generic/odp_packet.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 853d3baa9..a6feadbd8 100644 --- a/platform/linux-generic/odp_packet.c +++ b/platform/linux-generic/odp_packet.c @@ -816,10 +816,7 @@ odp_packet_t odp_packet_alloc(odp_pool_t pool_hdl, uint32_t len) odp_packet_t pkt; int num, num_seg; - if (odp_unlikely(pool->params.type != ODP_POOL_PACKET)) { - __odp_errno = EINVAL; - return ODP_PACKET_INVALID; - } + ODP_ASSERT(pool->params.type == ODP_POOL_PACKET); if (odp_unlikely(len > pool->max_len)) return ODP_PACKET_INVALID; @@ -839,10 +836,7 @@ int odp_packet_alloc_multi(odp_pool_t pool_hdl, uint32_t len, pool_t *pool = pool_entry_from_hdl(pool_hdl); int num, num_seg; - if (odp_unlikely(pool->params.type != ODP_POOL_PACKET)) { - __odp_errno = EINVAL; - return -1; - } + ODP_ASSERT(pool->params.type == ODP_POOL_PACKET); if (odp_unlikely(len > pool->max_len)) return -1;
