muvarov replied on github web page: helper/m4/configure.m4 @@ -8,14 +8,13 @@ AC_ARG_ENABLE([test-helper], AM_CONDITIONAL([test_helper], [test x$test_helper = xyes ]) ########################################################################## -# Enable/disable helper-ext -# platform specific non portable extensions +# Enable/disable Linux helpers ########################################################################## -helper_linux=no +helper_linux=yes AC_ARG_ENABLE([helper-linux], - [ --enable-helper-linux build helper platform extensions (not portable)], - [if test "x$enableval" = "xyes"; then - helper_linux=yes + [ --enable-helper-linux enable Linux helpers],
Comment: I think no. You have some option by default. They might be on or off. ./configure can change default settings. And help should print right information about that. --enable for already enabled option makes no sense. > Petri Savolainen(psavol) wrote: > Done in v3 >> Petri Savolainen(psavol) wrote: >> I think all config options we have added should be documented as enable-xxx. >> The help output is harder to read when some options are documented as >> enable-xxx (do xxx) and others disable-xxx (don't do xxx). The disable >> option is available in any case. >> >> I trust only on the defaults printed by ./configure, not the help >> documentation which may be outdated. >>> muvarov wrote >>> @lumag I guess just copy paste code from odp to ofp :) >>>> muvarov wrote >>>> if you enable it by default ./configure --help should print >>>> --disable-helper-linux disable Linux helpers. >>>>> Dmitry Eremin-Solenikov(lumag) wrote: >>>>> As you are touching this line, could you please use AS_HELP_STRING here? >>>>>> Petri Savolainen(psavol) wrote: >>>>>> corrected in v2 >>>>>>> Josep Puigdemont(joseppc) wrote: >>>>>>> Shouldn't we add a test now checking if $enableval is "no" here? https://github.com/Linaro/odp/pull/395#discussion_r162008768 updated_at 2018-01-17 10:24:29
