* typedef struct { } ODP_ALIGN() test_t; is correct
* typedef struct ODP_ALIGN() {} test_t; is correct and
preferred from gcc standards
* typedef struct {} test_t ODP_ALIGN() discards align
Had segfaults on gcc-7 using that

Signed-off-by: Ilias Apalodimas ilias.apalodi...@linaro.org

----------------github------------------------
/** Email created from pull request 398 (apalos:align)
 ** https://github.com/Linaro/odp/pull/398
 ** Patch: https://github.com/Linaro/odp/pull/398.patch
 ** Base sha: 520c170d758f2d37554631bf1467ec50e027cd3e
 ** Merge commit sha: 3e50fd2a906ee8648f7deba29f1f7bb4cce49951
 **/
----------------/github------------------------

----------------checkpatch.pl------------------------
ERROR: open brace '{' following function declarations go on the next line
#999: FILE: test/validation/api/chksum/chksum.c:17:
+static uint8_t ODP_ALIGNED(4) ip_hdr_test_vect[NUM_IP_HDR][IP_HDR_LEN] = {

ERROR: open brace '{' following function declarations go on the next line
#1008: FILE: test/validation/api/chksum/chksum.c:41:
+static struct udp_test_vect_s ODP_ALIGNED(4) udp_test_vect[NUM_UDP] = {

ERROR: open brace '{' following function declarations go on the next line
#1017: FILE: test/validation/api/chksum/chksum.c:89:
+static uint8_t ODP_ALIGNED(4) udp_test_vect_long[] = {

total: 3 errors, 0 warnings, 0 checks, 760 lines checked


to_send-p-000.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
----------------/checkpatch.pl------------------------

Reply via email to