https://bugs.linaro.org/show_bug.cgi?id=3577

            Bug ID: 3577
           Summary: classification: multiqueue CoS will always fail
           Product: OpenDataPlane - linux- generic reference
           Version: master
          Hardware: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: ---
         Component: Classification
          Assignee: bala.manoha...@linaro.org
          Reporter: or...@starflownetworks.com
                CC: lng-odp@lists.linaro.org
  Target Milestone: ---

When creating a multiqueue CoS (`num_queue` > 1), the `queue` field in the
`cos_t` structure is set to ODP_QUEUE_INVALID:

  if (param->num_queue > 1) {
    ...
    cos->s.queue = ODP_QUEUE_INVALID;
    ...
  } else {
    cos->s.queue = param->queue;
  }

However, when classifying the packet in cls_classify_packet() the `queue` field
is tested for validity:

  if (cos->s.queue == ODP_QUEUE_INVALID ||
      cos->s.pool == ODP_POOL_INVALID)
    return -EFAULT;

To fix this, this test on `cos->s.queue` shouldn't be mandatory for a
multiqueue CoS.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to