RFC 7634 defines ChaCha20-Poly1305 algorithm for IPsec. RFC 8221 marks it at 
level 'SHOULD':
   ENCR_CHACHA20_POLY1305 was not ready to be considered at the time of
   [RFC7321].  It has been recommended by the Crypto Forum Research
   Group (CFRG) and others as an alternative to AES-CBC and AES-GCM.  At
   the time of writing, there are not enough ESP implementations of
   ENCR_CHACHA20_POLY1305 to be able to introduce it at the SHOULD+
   level.  Its status has been set to SHOULD and is expected to become
   MUST in the long term.

----------------github------------------------
/** Email created from pull request 428 (lumag:chacha-poly1305)
 ** https://github.com/Linaro/odp/pull/428
 ** Patch: https://github.com/Linaro/odp/pull/428.patch
 ** Base sha: 44974a09b01c79adb9637a5dff38539598a76737
 ** Merge commit sha: 516808773882a012c221502d190787c1cdddd1b9
 **/
----------------/github------------------------

----------------checkpatch.pl------------------------
total: 0 errors, 0 warnings, 0 checks, 42 lines checked


to_send-p-000.patch has no obvious style problems and is ready for submission.
WARNING: Prefer ARRAY_SIZE(a)
#2030: FILE: test/validation/api/crypto/odp_crypto_test_inp.c:708:
+#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))

CHECK: Avoid CamelCase: <pName>
#2607: FILE: test/validation/api/crypto/odp_crypto_test_inp.c:1285:
+       for (i = 0; crypto_suite[i].pName; i++) {

total: 0 errors, 1 warnings, 1 checks, 2592 lines checked


to_send-p-001.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 0 checks, 231 lines checked


to_send-p-002.patch has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 0 checks, 111 lines checked


to_send-p-003.patch has no obvious style problems and is ready for submission.
CHECK: Alignment should match open parenthesis
#194: FILE: test/validation/api/ipsec/test_vectors.h:52:
+KEY(key_rfc7634, 0x80, 0x81, 0x82, 0x83, 0x84, 0x85, 0x86, 0x87,
+                0x88, 0x89, 0x8a, 0x8b, 0x8c, 0x8d, 0x8e, 0x8f,

total: 0 errors, 0 warnings, 1 checks, 217 lines checked


to_send-p-004.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 0 checks, 43 lines checked


to_send-p-005.patch has no obvious style problems and is ready for submission.
----------------/checkpatch.pl------------------------

Reply via email to