Michaël CATANZARITI wrote:
Hi,
Christophe de Vienne wrote:
Hi,
I'm currently working on the threading wrappers, mainly hidding the implementation details dependant from the thread system we use.
I have a few questions :
1) In Thread::~Thread(), the join is done directly instead of using Thread::join, which make code duplication. Is there a particular reason for that ?
You're right Thread::join must be directly called.
However I think I did not call it directly because of a deadlock under Windows.
Shall I give it a try ? Someone will have to test to me.
[snip question about giving access to Impl]
I don't think so. Thread overrides must be platform independant, so the Impl struct has not be known.
OK. It's almost done.
More questions may comes later :-)
And here it comes !
CriticalSection initialise a recursive mutex. For most use it's OK, but some people may need a simple one for performances issue, and there is a third one which can report errors.
What I propose is to give the type of mutex we need to the constructor, with a default to recursive so it won't break code.
Regards,
Christophe
