[
https://issues.apache.org/jira/browse/LOGCXX-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thorsten Schöning resolved LOGCXX-356.
--------------------------------------
Resolution: Fixed
I added the changes to log4cxx.h.hw directly where the extern statements are
used. Else we would need those pragmas everywhere where the macros are used and
the pragmas are not already present.
> apache-log4cxx-0.10.0\src\main\include\log4cxx\spi\configurator.h(57) :
> warning C4231: nonstandard extension used : 'extern' before template explicit
> instantiation
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LOGCXX-356
> URL: https://issues.apache.org/jira/browse/LOGCXX-356
> Project: Log4cxx
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.10.0
> Environment: MS Windows 7 (32 bit), MS Visaul Studio C++ 2008
> Reporter: Mitja Gomboc
> Assignee: Curt Arnold
> Priority: Trivial
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Compilers show warning:
> apache-log4cxx-0.10.0\src\main\include\log4cxx\spi\configurator.h(57) :
> warning C4231: nonstandard extension used : 'extern' before template explicit
> instantiation
> Can we use the same workaround as in
> "apache-log4cxx-0.10.0\src\main\include\log4cxx\log4cxx.h" ?
> #if defined(_MSC_VER)
> #pragma warning ( push )
> #pragma warning ( disable: 4231 )
> #endif
> ....
> #if defined(_MSC_VER)
> #pragma warning (pop)
> #endif
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
