Rhys is correct. We shouldn't commit patches before we are sure they compile. Moreover, Unit test should be done for most of them. Some of them were my patches sent by email, but without UTests, and some feedback shouldn't go in so easily.
I have some comments regarding commits that are only whitespaces. Is difficult to watch, follow or filter (if you are on Windows, probably, you do not see them). For these issues though, Thorsten, let me give you a helping hand. I'll try to fix the trunk when back home. It seems that Apache has indeed licenses for Windows, so hopefully we'll catch this kind of problems easily. Have a nice day, Alex On Feb 12, 2014 4:26 AM, "Thorsten Schöning" <tschoen...@am-soft.de> wrote: > Guten Tag Rhys Ulerich, > am Mittwoch, 12. Februar 2014 um 04:44 schrieben Sie: > > > Please, please don't apply and commit patches from issues unless you > > can confirm build correctly afterwards. > > Sorry, I didn't want to bother you, my only intention was to take what > I had the feeling was the boring part of reading through the bugs and > let us fix the problems later together. > > Shall I branch my patches out and revert the trunk? > > Mit freundlichen Grüßen, > > Thorsten Schöning > > -- > Thorsten Schöning E-Mail:thorsten.schoen...@am-soft.de > AM-SoFT IT-Systeme http://www.AM-SoFT.de/ > > Telefon...........05151- 9468- 55 > Fax...............05151- 9468- 88 > Mobil..............0178-8 9468- 04 > > AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln > AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow > >
