> (Disclaimer: I only briefly skimmed the PR, so I might got things wrong.) > > Some thoughts: > - I would not impose on applications should handle signals. This could > be a mayor annoyance, especially if applications needs being changed of that > (this refering to the docs about signalfd etc.) >
My objective is to not define how applications should handle signals, the documentation is really in terms of "here's a way you can handle signals better." That should be more clear though, so I can update that. > - A question: does log4cxx use signals of its own? > If not, I would use the approach to block all signals before > pthread_create() > and then restore them afterwards. > Log4cxx does not use any signals on its own, so the question is should we do this automatically or not? If you're using signalfd or something similar, there's no need to block signals before a thread starts, as it bypasses the issue at that point. -Robert Middleton
