At 10:01 11.06.2002 -0700, you wrote: > > This is very good work. > >Thank you. > > > 1) Option names (i.e. javabeans properties) are always in bold in the > > javadocs. > >Where do I change this? Did I miss a few places in the descriptions?
I thought you had not put property names in bold but you have. My mistake. > > 2) You have stuck to "my" preferred formatting style: >[snip] > > The difference is quite small but there is a difference nonetheless. > > We'll move log4j code from my style to Sun's style little by > > little. We can start by fresh code written for log4j 1.3. I'll write a > > codingstyle.html page explaining all this as soon as I get the time. > > Previous to this email, this was all a mental note so you had no way > > of knowing. > >I think we should just come up with an optional ant task that will format >the way we want to format. There are enough tools out there to do this. >Then we could just run it over new contributions to format them before >checkin. Once I am in an existing file, I can conform to whatever style is >already used without too much effort. I wonder how other projects deal with this issue. > > Coming back to your contribution, it contains an interesting bug that > > you will discover immediately when you write the first test case. I > > won't say more. I might even be wrong but the test cases will show. By > > the way, did I thank you for your excellent work? > >Ack! I know there is a bug lurking there somewhere. I can't wait to find >it. :-) Hint: It's not a logic bug. It is related JavaBeans introspection. A test case soliciting a configurator should reveal the problem. >And thanks again. I am hoping to get some version of the Watchdog stuff >checked in. Can you point me at some of the time manager related api's you >mentioned previously? I am going to look at it later tonight, if I get the >chance. But first...there's work. See java.util.Timer and java.util.TimerTask: http://java.sun.com/j2se/1.3/docs/api/java/util/Timer.html http://java.sun.com/j2se/1.3/docs/api/java/util/TimerTask.html What I have in mind is very closely related. To answer a previous question, SocketWatchdog does not fit into the Timer framework, only periodic tasks do. >-Mark -- Ceki SUICIDE BOMBING - A CRIME AGAINST HUMANITY Sign the petition: http://www.petitiononline.com/1234567b I am signatory number 22106. What is your number? -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
