One thing that isn't being enforced is the order of keyword modifiers. The following change would enable that.
change
<modifier>
<order>public|protected|private|abstract|static|final|synchronized|transient|volatile|native|strictfp</order>
</modifier>
to
<modifier>
<enable>true</enable>
<order>public|protected|private|abstract|static|final|synchronized|transient|volatile|native|strictfp</order>
</modifier>
Otherwise, when you run Jalopy and your keywords are out of the order specified above, they won't get corrected and checkstyle will still report errors.
As a side note, I can't figure out how to make work with Jalopy is changing single line comment lines to be 79 characters long or less. They remain unmodified where multi-line comments get corrected. Anyone know a way to do that? If not, then single line comments will always require hand-modification to bring them into compliance. Jalopy alone won't do the trick.
Oh, one other thing...
I order to run the "editJalopyPreferences" target, I had to move the following code from inside the "runJalopy" target to a place outside that target so both targets could see it:
<path id="jalopy.path">
<fileset dir="${jalopy.lib}">
<include name="*.jar" />
</fileset>
</path>
I also made the jalopy targets which weren't depending on "init" to depend on init to be consistent with the other targets. I'm attaching a diff of my preferred changes against the current build.xml.
Jake
At 11:15 AM 2/15/2003 -0800, you wrote:
Done. I changed "continuation" and "general" from 4 to 2. If there are any
other changes that should be applied, let me know.
-Mark
> -----Original Message-----
> From: Ceki Gulcu [mailto:[EMAIL PROTECTED]]
> Sent: Saturday, February 15, 2003 7:38 AM
> To: [EMAIL PROTECTED]
> Subject: Indentation!!!
>
>
>
> Mark,
>
> I'd just like to point out that although log4j generally adheres to Suns
> coding conventions, it uses 2 spaces for indentation and not 4. I would
> like to request that the file sunCodingConvention.xml be modified to
> reflect this difference. TIA,
>
>
> --
> Ceki
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
121a122,130
> <!-- Construct Jalopy classpath -->
> <!-- ================================================================= -->
> <path id="jalopy.path">
> <fileset dir="${jalopy.lib}">
> <include name="*.jar" />
> </fileset>
> </path>
>
> <!-- ================================================================= -->
124c133
< <target name="runJalopy">
---
> <target name="runJalopy" depends="init">
125,129d133
< <path id="jalopy.path">
< <fileset dir="${jalopy.lib}">
< <include name="*.jar" />
< </fileset>
< </path>
143c147
< <target name="editJalopyPreferences">
---
> <target name="editJalopyPreferences" depends="init">--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
