Raymond, > I finally have more time as a major deadline has passed at > work. I was > thinking about writing an improved JDBC appender. My intention is to > create a new appender from scratch. As discussed previously, > I figured > I would have an abstract base class with an abstract getConnection() > class and two concrete derivatives; one for getting the > connection from > a JNDI context and one for getting the connection from the > DriverManager.
That is one way. Another way, similar to what Paul Smith was articulating, would be to allow a configuration value for a class that implements a known interface that returns a connection (and maybe a host of other behavior information). I could go either way; the most important point is the clarity of design so that developers a) understand what needs to be overridden/written where. b) understand what information is needed for configuration. Your way might be better for configuration issues (trying to set the configuration items on a "connection class" configuration could get hairy). > 1) The original JDBCAppender class has a buffer where it stored the > events until a limit is hit. I'm not sure I understand the rationale > behind this. Doesn't this cause most loggings to be fast but > once in a > while one client pays the bill for the rest? It also seems > to have been > a source of bugs in the past. Does anyone have a compelling > reason for > including it in the new appenders? I am not an expert, but I think the hope was to achieve some kind of efficiency by committing batches of events instead of each individual event? You might want to seach the mail archives for discussions. http://marc.theaimsgroup.com/?l=log4j-user&r=1&w=2 > 2) Is there a good place to look to get a feel for how the > configuration works? http://nagoya.apache.org/wiki/apachewiki.cgi?Log4JProjectPages/JDBCAppenderC onfiguration has some description of the JDBCAppender configuration settings. Is that what you are looking for? Other than that, it is the usual method for configuring an appender. Also, Ceki has mentioned that JDBCAppender is up for a re-write for v1.3 and that he was going to be working on it. I'm sure he has some thoughts about the requirements. looking forward to see what you come up with, -Mark --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
