At 07:14 PM 9/11/2003 +1000, Paul Smith wrote:
> Here is a practical consideration. I do not think there is much leeway
> regarding location of the %T conversion character. It must be always at
> the
> end. Right?

Umm, no actually. I think it should be allowed anywhere.  For a file
appender it would look pretty crap anywhere else, but for Chainsaw as an
example, this is the Pattern Layout conversion I am using for the detail
panel, and it works a treat... (mind you I am only showing a single event at
a time):

Level%p
Logger%c
TIme%d
Thread%t
Message%m
Location%l
NDC%x
MDC%X
Class%C
Method%M
Line%L
File%F
PropertiesProperties support is missing from PatternLayout at this time, stay tuned.
ThrowableThrowable Information support is missing from PatternLayout at this time, stay tuned


Paul, while I agree that generally speaking %T need not always be at the end, even in your usage case Throwable is shown last. However, there is an interesting case where the use wants to override the way the stack trace is printed. For example when she wants nested exceptions to be printed too...

In conclusion, let us add %T (or %exception, %throwable). I'll also change PatternLayout to keep track of the of the PattenConverters that handle exceptions and adjust ignoresThroable accordingly. I'll work on Joran and come back to this issue later. Please remind me if I forget.



--
Ceki G�lc�

     For log4j documentation consider "The complete log4j manual"
     ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp

     See you in November at ApacheCon US 2003 in Las Vegas.
     http://apachecon.com/



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to