Howdy, >> Does this break configureAndWatch? > >No, configureAndWatch only uses Strings which points to a file name. Thus >it never uses the doConfigure that uses a URL. The code change I made >simply closes the input stream from the URL exactly like the string version >of doConfigure does. Infact, this fix is necessary to be able to edit the >"default" initialization file that log4j uses, so a configureAndWatch could >potentially be added to LogManager now to configure from the "default" >initialization file, and then watch it for changes.
OK, I'm glad you looked into it. >method / capability was added. If backwards compatibility of the >Heirarchy.resetConfiguration method signature is needed / desired a method >with the original signature could be added, and then call the newly Complete backwards compatibility is indeed desired, especially in a point release, at least by me. Adding this tiny method is fine IMHO. >modified one with a value of true. This would then provide complete >backwards compatibility with no changes to existing signatures while also >providing new functionality. Their would only be one additional method in >the LoggerRepository interface, but I doubt many people are implementing or >extending that interface outside of log4j itself. I agree with your doubt. Nonetheless I'd like to be 100% backwards compatible. Well, I'm sold on these patches ;) Yoav Shapira This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
