Mark,
Could you please clarify the intent of the isActive() method and how is it used in practice? Is it similar in intent to the 'closed' variable (protected access) in AppenderSkeleton?
At 05:49 PM 11/10/2004, Andy McBride wrote:
I've only had chance to have a quick look through the receiver api, not used it in anger yet.
One thing I did notice was that the javadoc for PluginSkeleton states that subclasses are required to implement the isActive() method from the Plugin interface but PluginSkeleton provides a perfectly good active property along with an implementation of the isActive() method.
Some existing receiver classes follow the javadoc and provide redundant implementations of both property and method whereas others just use the inherited ones.
I suggest amendment of the javadoc in PluginSkeleton and removal of the isActive() method and associated property in the following classes:
JMSReceiver MulticastReceiver PluginTestCase.PluginTester SocketHubReceiver XMLSocketReceiver
Cheers
Andy
-- Ceki G�lc�
For log4j documentation consider "The complete log4j manual"
http://www.qos.ch/shop/products/eclm/
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
