Oh my, I can't believe I didn't learn from a mistake I did a while back with an appender I wrote for my job..
Thanks for picking this up. Do you think we could enforce this by setting this variable in the super.close() ? it's very easy to miss. cheers, Paul Smith > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Tuesday, November 16, 2004 4:36 AM > To: [EMAIL PROTECTED] > Subject: cvs commit: logging-log4j/src/java/org/apache/log4j/varia > ListAppender.java > > > ceki 2004/11/15 09:36:27 > > Modified: src/java/org/apache/log4j/varia ListAppender.java > Log: > Once an appender is closed it can no longer be used. > > Revision Changes Path > 1.3 +3 -1 > logging-log4j/src/java/org/apache/log4j/varia/ListAppender.java > > Index: ListAppender.java > =================================================================== > RCS file: > /home/cvs/logging-log4j/src/java/org/apache/log4j/varia/ListAppend > er.java,v > retrieving revision 1.2 > retrieving revision 1.3 > diff -u -r1.2 -r1.3 > --- ListAppender.java 15 Nov 2004 17:33:37 -0000 1.2 > +++ ListAppender.java 15 Nov 2004 17:36:27 -0000 1.3 > @@ -37,7 +37,7 @@ > * > */ > public final class ListAppender extends AppenderSkeleton { > - private final List model = new ArrayList(); > + private List model = new ArrayList(); > > /** > * Returns a writeable, BUT cloned List of all the > LoggingEvents that are contained > @@ -70,7 +70,9 @@ > * @see org.apache.log4j.Appender#close() > */ > public void close() { > + closed = true; > clearModel(); > + model = null; > } > > /** > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
