At 10:23 PM 12/1/2004, Curt Arnold wrote:

I've updated the bug report with a shot at replaying location information.

Thank you.

The JoranConfigurator normalizes everything so all JoranInterpreter sees is local names ("configuration", "logger") etc in the "http://jakarta.apache.org/log4j/"; namespace.

Hmm, we should use the "http://logging.apache.org/log4j/"; namespace or maybe just "http://logging.apache.org/";.


I think doConfigure should return a boolean to relay whether the configuration was successful. You couldn't rely on getErrorList.size() > 0 to indicate failure since a warning would go in the error list, but would not cause doConfigure to fail.

Good point. However, keep in mind that none of the joran actions will add a warning to the error list. Only serious errors are added there. So we are left with the parser. From the top of your head, do you have an example of a warning reported by the parser which would be less serious than an error? If you look at the checkIfWellformed method, you'll notice any fatalError, error or warning reported by the parser will cause joran to skip configuration. In short, the current wellformedness checks do not differentiate between fatalError, error and warning messages reported by the parser.



-- Ceki G�lc�

The complete log4j manual: http://qos.ch/eclm
Professional log4j support: http://qos.ch/log4jSupport




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to