On Mar 7, 2005, at 4:49 AM, Ceki G�lc� wrote:
Do you think it is wise to go into all this trouble?
DOMConfiguration.doConfigure(Element) is used within Apache Excalibur (http://cvs.apache.org/viewcvs.cgi/excalibur/trunk/containerkit/logger/ src/java/org/apache/avalon/excalibur/logger/ Log4JConfLoggerManager.java?root=Apache-SVN&rev=22712&view=markup) to configure log4j from an in-memory DOM tree. There is not a simple modification that would allow that code to work with both 1.2 and 1.3 without those methods being restored.
The method was clearly part of the log4j 1.2 API (that is it wasn't some internal method that wasn't intended for use by end-users) and it served a useful and unique purpose (configuration from a subtree of an larger document). By restoring that part of our API, we prevent Excalibur from working only with 1.2 or writing an equivalently complex workaround. In addition to restoring Excalibur, it should also prevent that issue from reappearing when more people start evaluating log4j 1.3.
The actual implementation was fairly simple and clear. The bulk of the commit was cut and paste from the existing DOMConfigurator tests. It would have been nice if the tests weren't so bulky, but it would have been a lot more effort to try to write new more compact tests.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
