Curt Arnold wrote:
Was your performance comparison between the AsyncAppender in log4j
1.2.14 or AsyncAppender from earlier log4j's?
Hi Curt,
I have used 1.2.14 for my comparisons. You will be able to run the test
yourself.
> Since you mentioned that
you discard events in peak load, you should set blocking=false on the
new AsyncAppender to keep the comparisons fair.
Of course I did that.
The JDK 1.5 dependency would be a blocker for it going into the log4j
1.2 core. Could be made into a "companion" if it offered a compelling
performance advantage, but I'd much rather find a small performance
tweak for AsyncAppender than to introduce an alternative.
Okay, "companion" sounds good enough. The most important thing for me is
getting community exposure, so it gets proper review and testing.
Nothing's worse than a bug in your logging framework that takes down
your application server.
Please note, that raw throughput performance is *not* the objective of
this implementation. That's more of a side-effect. The most important
thing for this implementation is to get rid of the extreme lock
contention that is introduced by synchronized(buffer) in AsyncAppender.
There is still the synchronization on the Logger instance however, but
that is a lesser problem, since there is not only one Logger instance in
real-world applications.
Can't speculate too much without seeing the code. If you'd like to
create a bug and then attach a file to the bug (it is a two step process
in Bugzilla), we'd look at it. If you do, please make sure that could
code contains the proper notice in the header
(http://www.apache.org/legal/src-headers.html).
I will do that tomorrow.
> You should review the
Contributor License Agreement (CLA)
Don't worry. I have been a Jakarta committer for the HttpComponents
project for many years.
Kind regards
Ortwin Glück
--
[web] http://www.odi.ch/
[blog] http://www.odi.ch/weblog/
[pgp] key 0x81CF3416
finger print F2B1 B21F F056 D53E 5D79 A5AF 02BE 70F5 81CF 3416
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
