DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=43158>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43158 ------- Additional Comments From [EMAIL PROTECTED] 2007-08-21 21:27 ------- (In reply to comment #8) > Some comments: > > 1) If there has been no previously saved XML file with the plugins defined, > the > radio button in the No Receiver panel should be greyed out. It's of no use > until you have saved at least once. yes. it's nice to have that. this is implemented in the new patch > > 2) Rather than LogUI call the receiverPanels save config method, shouldn't the > ReceiverPanel implement the SettingsListener interface and have LogUI register > it as a listener? That would appear cleaner IMHO. Initially i didn't use it as there's nothing to load in ReceiversPanel. But yes it is nice to do it in the standard way. Fixed in the new patch. > > 3) In the try block when saving, the error log does not include the > exception. > Unfortunately since this method is also called during exit of the process, you > never see the problem. I wonder if the (*gasp*) Exception.printStackTrace() > should be used instead? I'm actually having trouble getting it to save Added a e.printStackTrace() > anything, I don't see any receiver-configs.xml file in the .chainsaw > directory? > I added a local e.printStackTrace() and see this: > > java.lang.ClassCastException: > org.apache.log4j.chainsaw.zeroconf.ZeroConfPlugin > at > org.apache.log4j.chainsaw.receivers.ReceiversPanel.saveReceiverConfigurations(ReceiversPanel.java:596) > at org.apache.log4j.chainsaw.LogUI.exit(LogUI.java:1418) > at > org.apache.log4j.chainsaw.osx.OSXIntegration$1.invoke(OSXIntegration.java:57) > at $Proxy0.handleQuit(Unknown Source) > at com.apple.eawt.Application$6.run(Application.java:396) > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209) > at java.awt.EventQueue.dispatchEvent(EventQueue.java:461) > at > java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:269) > at > java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190) > at > java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:184) > at > java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:176) > at java.awt.EventDispatchThread.run(EventDispatchThread.java:110) > > You're casting all Plugins to the Receivers class type, but that's a big > assumption. Not every Plugin registered is a Receiver. Sorry about this, I just forgot the ZeroConf. Anyway I think we have to save only the receivers. Used an instanceof and fixed it in the new patch.. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
