On Aug 23, 2007, at 12:22 AM, Scott Deboy wrote:

It looks like my most recent commit isn't sufficient. I'll see if I can improve it before you cut a RC.



-----Original Message-----
From: Scott Deboy [mailto:[EMAIL PROTECTED]
Sent: Wed 8/22/2007 10:19 PM
To: Log4J Developers List
Subject: RE: Bug list survey

Looks good -

A few things:

1. helpers/Constants.java is in both extras & component. I looked in helpers for other dups, but didn't see any - not sure if we have other dups..

2. When I try to use UDPReceiver (with XMLDecoder), it looks like it's trying to go out to the internet to retrieve the DTD. Here's the exception:

log4j:ERROR Could not find [log4j.dtd]. Used [sun.misc.Launcher [EMAIL PROTECTED]
2e78c] class loader in the search.
java.net.ConnectException: Connection refused: connect
        at java.net.PlainSocketImpl.socketConnect(Native Method)
        at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:333)
at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java: 195)


To prevent this, I had to add log4j's src/main/resources path to my classpath.. Of course, I'm testing from inside eclipse, so this may not be an issue once I try out the final jars. Just curious if we should change how the entity resolver works (as you mentioned in a previous email).


Will review tomorrow.


I ended up calling MDC.put on the main Chainsaw thread to get the chainsaw-log application & hostname mdc entries to appear, and I remove them in the workerthread in ChainsawAppenderHandler, so I think we're ok with properties in Chainsaw for now.

I think we're ready for a 1.2.15 rc..


Need to remove logger.dtd from log4j/trunk before cutting a RC.

By the way, I'm not sure where we left event properties - not important now, just curious.


AFAIR:

You can set properties on LoggerRepositoryExImpl, but they aren't propagated to generated events. LoggingEvent has getProperties() which is currently synonymous with getMDC(). EnhancedPropertyLayout supports %X to list all MDC values. XMLLayout can output <log4j:properties> element with MDC values if you set the properties attribute to true, XSLTLayout layout outputs MDC values by default. Supporting the last three when used with pre-1.2.15 releases requires serialization tricks and could be time consuming.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to