Re: [PROPOSAL] SocketHubAppender change - allow auto port choice

[Paul Smith]

That chunk seems just like the IDE at work moving things around.


Honestly, is that really that much of a deal?  I agree a total  
reformat of the class is not a good idea, but I don't see the need to  
get too anal about something like that..



But I didn't see much benefit from hiding the rest of the  
serverSocket from the extending class, so I first simplified the  
code to:

@@ -323,6 +336,7 @@
      ServerSocket serverSocket = null;
      try {
        serverSocket = new ServerSocket(port);
+        socketBound(serverSocket);
        serverSocket.setSoTimeout(1000);
      }
      catch (Exception e) {

which lets the extending class extract as much or little info out of  
the class as possible.  But once I did that, it seemed even more  
simple to use a protected method to create the socket which is  
easier to explain and lets the extending class do everything the  
other approaches do and more.


Looking at the ServerSocket I didn't really see anything much of use  
part from the address and port, but I guess it's just as easy to pass  
the whole thing.

Thanks Curt for committing a change.

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]