DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=44308>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44308 ------- Additional Comments From [EMAIL PROTECTED] 2008-02-07 18:35 ------- Ok, I _finally_ had time to sit down and review this. It does look quite substantial and generally well thought out. Here are my comments: RollbackableLoggerManager Ordering of rollback, should this be stack based instead? Be nice to indicate the size of the rollback state (number of undos) via jmx Operation to rollback just the most recent? LoggerManager getLevelByName - stylistic, but should that method declare the RuntimeException? since this class is designed for extension, should some thought be made towards making some of the methods final? (Effective Java) setRootLogLevel - declaring throwing RuntimeException? getConfiguredLoggers - is there an off-by-1 error there in th efor loop with the ++i instead of i++ ? LoggerManagerModelMBean + try { + getDelegate().getClass().getMethod("rollbackLogConfiguration", null); + modelMBeanOperations.add(rollbackLogConfiguration); + } catch (NoSuchMethodException expected) { + // nothing to do + } This seems a bit of a hack! :) Given RollbackableLoggerManager extends from LoggerManager, perhaps the same thought could be done to having a second RollbackableLoggerManagerModelMBean that has a doPostRegisterOtherSchtuff() style methods. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
