https://issues.apache.org/bugzilla/show_bug.cgi?id=46626
--- Comment #7 from Steven Willis <[email protected]> --- (In reply to comment #6) > Hi Steven, > > Thank you for the new patch. > > If APP-NAME is the current term, shouldn't the ivar be called 'appName' > instead of 'tag'? > > Gary Well, this class is still very old-school, it really targets classic syslog behavior. And that field is only called APP-NAME in newer syslog standards which are pretty different from the classic one. So I think it still makes sense to call it tag, since in the classic format, it's called tag. I suppose the exact spot in the code where the tag is added to the message could be moved from getPacketHeader() to anywhere the message is constructed in order to make it more semantically correct. Though I think that complicates the code quite a bit as there will be several more places where a change is necessary and the output will be the same. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
